Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

wazo-dird graphql: cannot use GraphiQL completion

Description

Given I am using GraphiQL with wazo-dird GraphQL endpoint
When I start typing a field
Then I don't see the autocompletion of the field

Expected: I see the autocompletion

Technical details: GraphiQL makes an additional query to get the introspection data used for autocompletion. The query is named __schema.

Zendesk Ticket IDs

None

Activity

Show:

Sébastien Duthil May 15, 2020 at 1:30 PM

Agreed, it’s the same requirements than the OpenAPI doc. I’ll remove the authentication check on this query.

François Blackburn May 14, 2020 at 5:44 PM
Edited

I see this endpoint as the same endpoint that /api/api.yml (a documentation endpoint) which is not authenticated.

However, I’m not against to have authentication (I prefer not, to keep consistency with openapi spec endpoint) but the part I’m not sure is to dedicate it an ACL. Only a valid token should be enough

Sébastien Duthil May 14, 2020 at 2:54 PM

Thanks for the reminder about the sprint. Will go in the next sprint.

__schema is not an implementation detail, it's in the GraphQL spec: https://graphql.org/learn/introspection/

I prefer having authentication everywhere than making an exception for this query.

François Blackburn May 13, 2020 at 1:59 PM
Edited

You forgot to add sprint to this ticket, so it will not be in this sprint (20.07)

Moreover, are you sure it is a good approach? IMO we should remove ACL check for this endpoint (dird.graphql.__schema), because is more a implementation detail that a real use case

Done

Details

Priority

Assignee

Reporter

Approvers

François Blackburn

Fix versions

Sprint

Zendesk Support

Created May 12, 2020 at 3:57 PM
Updated June 8, 2020 at 1:10 PM
Resolved May 22, 2020 at 10:21 AM