agid: call_record does not work on outgoing external call

Description

Given I have a user with ONLY call_record_outgoing_external_enabled set to True
Given I have an outcall
When the user calls an external number through the outcall
Then the call is not recorded
Expected: the call should be recorded

Technical details

With the following debugging added in wazo-agid:

diff --git a/wazo_agid/modules/call_recording.py b/wazo_agid/modules/call_recording.py index 9892cb9..e47ec9a 100644 --- a/wazo_agid/modules/call_recording.py +++ b/wazo_agid/modules/call_recording.py @@ -28,10 +28,12 @@ def record_caller(agi, cursor, args): user_id = agi.get_variable(dialplan_variables.USERID) if not user_id: + logger.debug('No user_id, aborting...') return caller = objects.User(agi, cursor, int(user_id)) if not caller: + logger.debug('No caller, aborting...') return is_internal = agi.get_variable(dialplan_variables.CALL_ORIGIN) != 'extern' @@ -40,6 +42,7 @@ def record_caller(agi, cursor, args): or (not is_internal and caller.call_record_outgoing_external_enabled) ) if not should_record: + logger.debug('Should not record, aborting...') return _start_mix_monitor(agi)

We get the "Should not record, aborting..." debug log.

Zendesk Ticket IDs

None

Activity

François Blackburn 
November 15, 2021 at 4:56 PM
(edited)

Note: acceptance test don’t fail on this use case … find why

acceptance doesn’t test call_record_outgoing_external_enabled

Done

Details

Priority

Assignee

Reporter

Approvers

Pascal Cadotte

Fix versions

Sprint

Zendesk Support

2
Created October 21, 2021 at 3:42 PM
Updated December 6, 2021 at 6:22 PM
Resolved November 29, 2021 at 4:36 PM