Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

'queueskillcat' table must be tenant-wide (includes clean deletion)

Description

queueskillcat (Call Center feature):

  • issue with deletion: skills categories are not removed when tenant deleted (must be fixed)

  • issue with skill category name: the name of a category must be unique (2 tenants cannot have the same category name) (must be fixed)

 

issue example #1:

  • we have a tenant T1 with a skill category named 'my category'

  • we delete the tenant T1

  • we create another tenant T2

  • we try to create a skill category named 'my category' for tenant T2 -> error, not possible (already used, because previous category not deleted)

issue example #2:

  • we have a tenant T1 with a skill category named 'my category'

  • we have another tenant T2

  • we try to create a skill category named 'my category' for tenant T2 -> error, not possible (already used by tenant T1)

Zendesk Ticket IDs

None

Activity

Show:

Charles Langlois October 25, 2023 at 7:35 PM

found some things to cleanup in wazo-ui: https://github.com/search?q=repo%3Awazo-platform%2Fwazo-ui%20skill%20category&type=code (sorry).

Charles Langlois October 24, 2023 at 1:52 PM
Edited

Definition of done(for review):

  • database table and code for queueskillcat deleted

  • API surface for queueskillcat(confd only?) deleted and scrubbed clean

  • any test coverage involving skill categories can be updated to uninvolve categories

any other considerations?

Nabil Ben Youssef October 23, 2023 at 2:01 PM
Edited

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Please merge at the same time the related PRs with the PR related to https://wazo-dev.atlassian.net/browse/WP-1169

Nabil Ben Youssef October 23, 2023 at 1:23 PM

Nabil Ben Youssef October 20, 2023 at 12:52 PM
Edited

What I will do:

  • [xivo-manage-db] adding an alembic script to :

    • deleting the queueskillcat

    • deleting the column catid in the queueskill table

  • [xivo-dao] updating the sqlalchemy schema/dao(s)

  • [wazo-confd] I must update the openapi for confd : category must be removed for /agents/skills

Done

Details

Priority

Assignee

Reporter

Approvers

Charles Langlois

Pair

Charles Langlois

Fix versions

Sprint

Parent

Labels

Zendesk Support

Created July 26, 2023 at 1:38 PM
Updated November 1, 2023 at 7:31 PM
Resolved October 30, 2023 at 5:39 PM

Flag notifications