500 when I update DHCP with invalid interface

Description

When I update /dhcp with an invalid interface
Then I received a status code 500 with message {"message": "Internal Server Error"}

wazo-confd.log

19-06-27 14:42:02,879 [1325] (ERROR) (flask.app): Exception on /1.1/dhcp [PUT] Traceback (most recent call last): File "/usr/lib/python3/dist-packages/flask/app.py", line 2292, in wsgi_app response = self.full_dispatch_request() File "/usr/lib/python3/dist-packages/flask/app.py", line 1816, in full_dispatch_request return self.finalize_request(rv) File "/usr/lib/python3/dist-packages/flask/app.py", line 1833, in finalize_request response = self.process_response(response) File "/usr/lib/python3/dist-packages/flask/app.py", line 2112, in process_response response = handler(response) File "/usr/lib/python3/dist-packages/wazo_confd/http_server.py", line 52, in after_request flush_sysconfd() File "/usr/lib/python3/dist-packages/wazo_confd/http_server.py", line 70, in flush_sysconfd publisher.flush() File "/usr/lib/python3/dist-packages/wazo_confd/_sysconfd.py", line 122, in flush self.flush_requests(session) File "/usr/lib/python3/dist-packages/wazo_confd/_sysconfd.py", line 136, in flush_requests self.check_for_errors(response) File "/usr/lib/python3/dist-packages/wazo_confd/_sysconfd.py", line 114, in check_for_errors response.text) wazo_confd._sysconfd.SysconfdError: sysconfd error: status 500 - <head> <title>Error response</title> </head> <body> <h1>Error response</h1> <p>Error code 500. <p>Message: <pre> can't generate commonconf file</pre> . <p>Error code explanation: 500 = Server got itself in trouble. </body>

xivo-sysconfd.log

2019-06-27 14:42:02,877 [1919] (ERROR) (xivo_sysconf.modules.commonconf): Error while generating commonconf: Traceback (most recent call last): File "/usr/sbin/xivo-create-config", line 192, in <module> main() File "/usr/sbin/xivo-create-config", line 41, in main config = load_config() File "/usr/sbin/xivo-create-config", line 49, in load_config result.update(load_config_dhcp(session)) File "/usr/sbin/xivo-create-config", line 77, in load_config_dhcp address = netifaces.ifaddresses(main_iface)[netifaces.AF_INET][0] ValueError: You must specify a valid interface name. 2019-06-27 14:42:02,878 [1919] (WARNING) (http_json_server): HttpReqError while executing commonconf_generate: can't generate commonconf file 2019-06-27 14:42:02,878 [1919] (INFO) (http_json_server): 'POST /commonconf_generate HTTP/1.1' 500 -

Zendesk Ticket IDs

None

Activity

Show:

Charles Langlois June 13, 2023 at 1:52 PM

Édouard Lopez June 27, 2019 at 3:19 PM

A more explicit message would help the user input correct value.

Done

Details

Priority

Assignee

Reporter

Fix versions

Zendesk Support

Created June 27, 2019 at 3:13 PM
Updated June 13, 2023 at 1:52 PM
Resolved June 13, 2023 at 1:52 PM

Flag notifications