Migrate fastapi branch to master

Done

Description

Branches to merge:

  • wazo-sysconfd: fastapi

  • wazo-sysconfd-client: fastapi

  • xivo-lib-python: fastapi

Zendesk Ticket IDs

None

relates to

Activity

Nabil Ben Youssef 
July 19, 2022 at 12:39 PM
(edited)

Warning

Be careful: there are two repositories, each of them having a ‘fastapi’ branch:

So each of them must merged in the right order.

 

I think you can follow the following steps:

  • for sysconfd-client : merge ‘fastapi' into ‘master’ (after that, we may have errors if the integration tests for sysconfd are executed in 'master’)

  • for sysconfd : in ‘fastapi’ branch, we must update integration_tests/test-requirements.txt:

https://github.com/wazo-platform/wazo-sysconfd-client/archive/fastapi.zip

-> https://github.com/wazo-platform/wazo-sysconfd-client/archive/master.zip

  • for sysconfd : merge ‘fastapi' into 'master’

Nabil Ben Youssef 
July 19, 2022 at 12:00 PM

Warning

As many developers worked on the FastAPI migration, we must double-check that the way the code has been written is “uniform” in all the branch before merging.

Sylvain Boily 
July 19, 2022 at 11:47 AM

Yes this is clearly what we expected. The merge will be probably this next Tuesday.

François Blackburn 
July 19, 2022 at 11:46 AM

Before merging branch please run all wazo-acceptance tests with this branch
(i.e. don’t merge this branch a day before freeze and take risk to rush release)

Details

Priority

Assignee

Reporter

Fix versions

Sprint

Zendesk Support

Created July 18, 2022 at 1:27 PM
Updated August 3, 2022 at 4:05 PM
Resolved July 27, 2022 at 3:59 PM